This repository has been archived by the owner on May 30, 2022. It is now read-only.
Add connection retry when starting Web and Runner #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In case of starting trento-web and the connection with the database fails, instead of failing immediately, retry to connect to the database 8 times with a variable backoff starting with 3 seconds. * In case of starting the trento-runner and the connection with the trento server fails, instead of failing immediately, retry to connect to the trento server 8 times with a variable backoff starting with 5 seconds. The above retries allows configuring the trento web and runner pods with probes so the container does not fail and reports errors while the database is still initializing.
arbulu89
approved these changes
Jan 31, 2022
nelsonkopliku
approved these changes
Jan 31, 2022
|
LGTM, thanks @flaviodsr ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of starting trento-web and the connection with the database
fails, instead of failing immediately, retry to connect to the database
8 times with a variable backoff starting with 3 seconds.
In case of starting the trento-runner and the connection with the
trento server fails, instead of failing immediately, retry to connect
to the trento server 8 times with a variable backoff starting with 5
seconds.
The above retries allows configuring the trento web and runner pods
with probes so the container does not fail and reports errors while
the database is still initializing.