This repository has been archived by the owner on May 30, 2022. It is now read-only.
Fix parse azure cloud data #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
requested review from
dottorblaster,
rtorrero,
stefanotorresi,
nelsonkopliku and
arbulu89
dottorblaster
approved these changes
Jan 31, 2022
arbulu89
reviewed
Jan 31, 2022
| log.Errorf("can't decode storage profile") | ||
| return cloudData | ||
| return entities.AzureCloudData{ | ||
| VMName: azureMetadata.Compute.Name, |
There was a problem hiding this comment.
mmm, I have some doubts about this.
Could we have the scenario where some of this fields don't exist and we have some other issue.
Or they are automatically filled with empty data?
The added test doesn't cover this situation at least
There was a problem hiding this comment.
it should work because the fields are not pointers so it will take the golang "zero value".
There was a problem hiding this comment.
@arbulu89 I've added a test, i still believe it is a bit anemic and we are basically testing that golang works but we can keep it as safety helmet
nelsonkopliku
approved these changes
Jan 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the azure cloud data parsers function in the hosts projector to use
mapstructureinstead of manually casting the nested interface/map fields.It also adds asserts to the host projector cloud discovery handler test.
Related to: #755