Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Do not make assumptions about the shape of the payload of checks catalog #793

Conversation

dottorblaster
Copy link
Contributor

This prevents the checks selection from panicking in the frontend when the catalog is empty.

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Error handling is always needed.
In the other hand, this won't fix the real issue, right? The one that for some reason the checks are not loaded

@dottorblaster
Copy link
Contributor Author

@arbulu89 exactly! I have to debug a running deployment for that, let's see what I discover

@dottorblaster dottorblaster merged commit 11aad91 into trento-project:main Feb 15, 2022
@dottorblaster dottorblaster added the bug Something isn't working label Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

3 participants