Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Implement cluster heatlh computation projection #817

Merged

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Feb 18, 2022

Hey folks! This is the improvement for the cluster health computation. It is based on projections in the discovery side and the checks results event. Hopefully it makes the work.
I have written some E2E tests and all goes green (they are not uploaded yet).

Some more details:
The partial healths fields is a map which stores all the partial healths of a resource, cluster in our case (but easy extendable for other resources like sap systems, hosts, etc). So the partial health is updated in the different events (now, when a new cluster discovery is done and the cluster checks results are executed). The 2 healths are stored, and the overall health computed.

I have a doubt with the new table though (health_states). I thinking if we should truncate the values of this table on web service boot up. This would have 2 benefits:

  • If for some reason we need the change the partial healths labels (hana_sr_health and config_checks by now), we would get rid off them, and we wouldn't have zombie entries.
  • We wouldn't have "old" health states. Maybe it is safe to restore the health to nothing on boot up, to not show old values, as it might be misleading.

@arbulu89 arbulu89 force-pushed the feature/cluster-health-computation branch from e520a9c to 4ea2a8e Compare February 18, 2022 16:41
@arbulu89 arbulu89 changed the title Implement cluster heatlh comuptation projection Implement cluster heatlh computation projection Feb 21, 2022
@arbulu89 arbulu89 force-pushed the feature/cluster-health-computation branch from 4ea2a8e to f359967 Compare February 21, 2022 09:22
@arbulu89 arbulu89 marked this pull request as ready for review February 21, 2022 09:37
Copy link
Member

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it is the best trade-off with the current architecture.
Not sure about truncating the table at boot i think we could merge this and then have a discussione on it.

@arbulu89 arbulu89 force-pushed the feature/cluster-health-computation branch from f359967 to 326fddc Compare February 21, 2022 14:07
@arbulu89 arbulu89 force-pushed the feature/cluster-health-computation branch from 326fddc to 74d27d1 Compare February 21, 2022 14:12
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.
Generally speaking I'd strive to find a clearer naming for things like HANASrHealth4 😄
but it is good enough here.

Not sure also about truncating health on boot, but let's discuss on that.

@arbulu89
Copy link
Contributor Author

arbulu89 commented Feb 21, 2022

LGTM as well. Generally speaking I'd strive to find a clearer naming for things like HANASrHealth4 smile but it is good enough here.

Not sure also about truncating health on boot, but let's discuss on that.

Update at: 1718d47

@arbulu89 arbulu89 force-pushed the feature/cluster-health-computation branch from 1f668a8 to 1718d47 Compare February 21, 2022 14:59
@arbulu89 arbulu89 merged commit 0fa9f14 into trento-project:main Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants