This repository has been archived by the owner on May 30, 2022. It is now read-only.
Implement cluster heatlh computation projection #817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks! This is the improvement for the cluster health computation. It is based on projections in the discovery side and the checks results event. Hopefully it makes the work.
I have written some E2E tests and all goes green (they are not uploaded yet).
Some more details:
The partial healths fields is a map which stores all the partial healths of a resource, cluster in our case (but easy extendable for other resources like sap systems, hosts, etc). So the partial health is updated in the different events (now, when a new cluster discovery is done and the cluster checks results are executed). The 2 healths are stored, and the overall health computed.
I have a doubt with the new table though (
health_states
). I thinking if we should truncate the values of this table on web service boot up. This would have 2 benefits:hana_sr_health
andconfig_checks
by now), we would get rid off them, and we wouldn't have zombie entries.