Skip to content

Commit

Permalink
Rename some reducer functions to use unset prefix
Browse files Browse the repository at this point in the history
  • Loading branch information
arbulu89 committed Aug 29, 2023
1 parent 6c07387 commit 93eace3
Show file tree
Hide file tree
Showing 12 changed files with 36 additions and 36 deletions.
4 changes: 2 additions & 2 deletions assets/js/state/databases.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const databasesListSlice = createSlice({
}
);
},
setDatabaseInstanceNotDeregistering: (state, { payload: instance }) => {
unsetDatabaseInstanceDeregistering: (state, { payload: instance }) => {
state.databaseInstances = updateInstance(
state.databaseInstances,
instance,
Expand Down Expand Up @@ -140,7 +140,7 @@ export const {
addTagToDatabase,
removeTagFromDatabase,
setDatabaseInstanceDeregistering,
setDatabaseInstanceNotDeregistering,
unsetDatabaseInstanceDeregistering,
} = databasesListSlice.actions;

export default databasesListSlice.reducer;
4 changes: 2 additions & 2 deletions assets/js/state/databases.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import databaseReducer, {
updateDatabaseInstanceHealth,
updateDatabaseInstanceSystemReplication,
setDatabaseInstanceDeregistering,
setDatabaseInstanceNotDeregistering,
unsetDatabaseInstanceDeregistering,
} from '@state/databases';
import {
databaseFactory,
Expand Down Expand Up @@ -157,7 +157,7 @@ describe('Databases reducer', () => {
databaseInstances: [instance],
};

const action = setDatabaseInstanceNotDeregistering(instance);
const action = unsetDatabaseInstanceDeregistering(instance);

const expectedState = {
databaseInstances: [
Expand Down
4 changes: 2 additions & 2 deletions assets/js/state/hosts.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const hostsListSlice = createSlice({
return host;
});
},
setHostNotDeregistering: (state, action) => {
unsetHostDeregistering: (state, action) => {
state.hosts = state.hosts.map((host) => {
if (host.id === action.payload.id) {
return { ...host, deregistering: false };
Expand Down Expand Up @@ -142,7 +142,7 @@ export const {
setHostListDeregisterable,
setHostNotDeregisterable,
setHostDeregistering,
setHostNotDeregistering,
unsetHostDeregistering,
startHostsLoading,
stopHostsLoading,
removeHost,
Expand Down
4 changes: 2 additions & 2 deletions assets/js/state/hosts.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import hostsReducer, {
setHostListDeregisterable,
setHostNotDeregisterable,
setHostDeregistering,
setHostNotDeregistering,
unsetHostDeregistering,
updateSelectedChecks,
} from '@state/hosts';
import { hostFactory } from '@lib/test-utils/factories';
Expand Down Expand Up @@ -62,7 +62,7 @@ describe('Hosts reducer', () => {
hosts: [host1, host2],
};

const action = setHostNotDeregistering(host1);
const action = unsetHostDeregistering(host1);

const expectedState = {
hosts: [{ ...host1, deregistering: false }, host2],
Expand Down
8 changes: 4 additions & 4 deletions assets/js/state/sagas/databases.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
removeDatabase,
removeDatabaseInstance,
setDatabaseInstanceDeregistering,
setDatabaseInstanceNotDeregistering,
unsetDatabaseInstanceDeregistering,
} from '@state/databases';

import {
Expand All @@ -28,7 +28,7 @@ import {
updateSAPSystemDatabaseInstanceHealth,
updateSAPSystemDatabaseInstanceSystemReplication,
setDatabaseInstanceDeregisteringToSAPSystem,
setDatabaseInstanceNotDeregisteringToSAPSystem,
unsetDatabaseInstanceDeregisteringToSAPSystem,
} from '@state/sapSystems';

import { getDatabase } from '@state/selectors/sapSystem';
Expand Down Expand Up @@ -130,8 +130,8 @@ export function* deregisterDatabaseInstance({
})
);
} finally {
yield put(setDatabaseInstanceNotDeregistering(payload));
yield put(setDatabaseInstanceNotDeregisteringToSAPSystem(payload));
yield put(unsetDatabaseInstanceDeregistering(payload));
yield put(unsetDatabaseInstanceDeregisteringToSAPSystem(payload));
}
}

Expand Down
12 changes: 6 additions & 6 deletions assets/js/state/sagas/databases.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ import {
removeDatabaseInstance,
appendDatabase,
setDatabaseInstanceDeregistering,
setDatabaseInstanceNotDeregistering,
unsetDatabaseInstanceDeregistering,
} from '@state/databases';
import {
removeDatabaseInstanceFromSapSystem,
upsertDatabaseInstancesToSapSystem,
setDatabaseInstanceDeregisteringToSAPSystem,
setDatabaseInstanceNotDeregisteringToSAPSystem,
unsetDatabaseInstanceDeregisteringToSAPSystem,
} from '@state/sapSystems';
import {
databaseFactory,
Expand Down Expand Up @@ -120,8 +120,8 @@ describe('SAP Systems sagas', () => {
expect(dispatched).toEqual([
setDatabaseInstanceDeregistering(instance),
setDatabaseInstanceDeregisteringToSAPSystem(instance),
setDatabaseInstanceNotDeregistering(instance),
setDatabaseInstanceNotDeregisteringToSAPSystem(instance),
unsetDatabaseInstanceDeregistering(instance),
unsetDatabaseInstanceDeregisteringToSAPSystem(instance),
]);
});

Expand All @@ -146,8 +146,8 @@ describe('SAP Systems sagas', () => {
text: `Error deregistering instance ${instance_number} from ${sid}.`,
icon: '❌',
}),
setDatabaseInstanceNotDeregistering(instance),
setDatabaseInstanceNotDeregisteringToSAPSystem(instance),
unsetDatabaseInstanceDeregistering(instance),
unsetDatabaseInstanceDeregisteringToSAPSystem(instance),
]);
});
});
4 changes: 2 additions & 2 deletions assets/js/state/sagas/hosts.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
removeHost,
setHostListDeregisterable,
setHostDeregistering,
setHostNotDeregistering,
unsetHostDeregistering,
appendHost,
} from '@state/hosts';

Expand Down Expand Up @@ -67,7 +67,7 @@ export function* deregisterHost({
})
);
} finally {
yield put(setHostNotDeregistering(payload));
yield put(unsetHostDeregistering(payload));
}
}

Expand Down
6 changes: 3 additions & 3 deletions assets/js/state/sagas/hosts.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
setHostListDeregisterable,
removeHost,
setHostDeregistering,
setHostNotDeregistering,
unsetHostDeregistering,
appendHost,
} from '@state/hosts';

Expand Down Expand Up @@ -93,7 +93,7 @@ describe('Hosts sagas', () => {

expect(dispatched).toEqual([
setHostDeregistering(payload),
setHostNotDeregistering(payload),
unsetHostDeregistering(payload),
]);
});

Expand All @@ -111,7 +111,7 @@ describe('Hosts sagas', () => {
text: `Error deregistering host ${hostname}.`,
icon: '❌',
}),
setHostNotDeregistering(payload),
unsetHostDeregistering(payload),
]);
});

Expand Down
4 changes: 2 additions & 2 deletions assets/js/state/sagas/sapSystems.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
removeSAPSystem,
updateSAPSystem,
setApplicationInstanceDeregistering,
setApplicationInstanceNotDeregistering,
unsetApplicationInstanceDeregistering,
} from '@state/sapSystems';
import { getSapSystem } from '@state/selectors/sapSystem';
import { notify } from '@state/actions/notifications';
Expand Down Expand Up @@ -130,7 +130,7 @@ export function* deregisterApplicationInstance({
})
);
} finally {
yield put(setApplicationInstanceNotDeregistering(payload));
yield put(unsetApplicationInstanceDeregistering(payload));
}
}

Expand Down
6 changes: 3 additions & 3 deletions assets/js/state/sagas/sapSystems.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
removeApplicationInstance,
updateSAPSystem,
setApplicationInstanceDeregistering,
setApplicationInstanceNotDeregistering,
unsetApplicationInstanceDeregistering,
} from '@state/sapSystems';
import { networkClient } from '@lib/network';
import { notify } from '@state/actions/notifications';
Expand Down Expand Up @@ -127,7 +127,7 @@ describe('SAP Systems sagas', () => {

expect(dispatched).toEqual([
setApplicationInstanceDeregistering(instance),
setApplicationInstanceNotDeregistering(instance),
unsetApplicationInstanceDeregistering(instance),
]);
});

Expand All @@ -151,7 +151,7 @@ describe('SAP Systems sagas', () => {
text: `Error deregistering instance ${instance_number} from ${sid}.`,
icon: '❌',
}),
setApplicationInstanceNotDeregistering(instance),
unsetApplicationInstanceDeregistering(instance),
]);
});
});
8 changes: 4 additions & 4 deletions assets/js/state/sapSystems.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export const sapSystemsListSlice = createSlice({
{ deregistering: true }
);
},
setApplicationInstanceNotDeregistering: (state, { payload: instance }) => {
unsetApplicationInstanceDeregistering: (state, { payload: instance }) => {
state.applicationInstances = updateInstance(
state.applicationInstances,
instance,
Expand All @@ -173,7 +173,7 @@ export const sapSystemsListSlice = createSlice({
{ deregistering: true }
);
},
setDatabaseInstanceNotDeregisteringToSAPSystem: (
unsetDatabaseInstanceDeregisteringToSAPSystem: (
state,
{ payload: instance }
) => {
Expand Down Expand Up @@ -224,9 +224,9 @@ export const {
removeSAPSystem,
updateSAPSystem,
setApplicationInstanceDeregistering,
setApplicationInstanceNotDeregistering,
unsetApplicationInstanceDeregistering,
setDatabaseInstanceDeregisteringToSAPSystem,
setDatabaseInstanceNotDeregisteringToSAPSystem,
unsetDatabaseInstanceDeregisteringToSAPSystem,
} = sapSystemsListSlice.actions;

export default sapSystemsListSlice.reducer;
8 changes: 4 additions & 4 deletions assets/js/state/sapSystems.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import sapSystemsReducer, {
removeDatabaseInstanceFromSapSystem,
updateSAPSystem,
setApplicationInstanceDeregistering,
setApplicationInstanceNotDeregistering,
unsetApplicationInstanceDeregistering,
setDatabaseInstanceDeregisteringToSAPSystem,
setDatabaseInstanceNotDeregisteringToSAPSystem,
unsetDatabaseInstanceDeregisteringToSAPSystem,
} from '@state/sapSystems';
import {
sapSystemFactory,
Expand Down Expand Up @@ -291,7 +291,7 @@ describe('SAP Systems reducer', () => {
applicationInstances: [instance],
};

const action = setApplicationInstanceNotDeregistering(instance);
const action = unsetApplicationInstanceDeregistering(instance);

const expectedState = {
applicationInstances: [
Expand Down Expand Up @@ -333,7 +333,7 @@ describe('SAP Systems reducer', () => {
databaseInstances: [instance],
};

const action = setDatabaseInstanceNotDeregisteringToSAPSystem(instance);
const action = unsetDatabaseInstanceDeregisteringToSAPSystem(instance);

const expectedState = {
databaseInstances: [
Expand Down

0 comments on commit 93eace3

Please sign in to comment.