Update tests for SaptuneDetails

trento-project · Sep 27, 2023 · fa43bac · fa43bac
1 parent 8272d61
commit fa43bac
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 9 deletions.
diff --git a/assets/js/components/SaptuneDetails/SaptuneDetails.stories.jsx b/assets/js/components/SaptuneDetails/SaptuneDetails.stories.jsx
@@ -7,15 +7,15 @@ import SaptuneDetails from './SaptuneDetails';
 
 const { hostname, id: hostID } = hostFactory.build();
 const {
-  package_version: packageVersion,
-  configured_version: configuredVersion,
-  tuning_state: tuningState,
   applied_notes: appliedNotes,
   applied_solution: appliedSolution,
+  configured_version: configuredVersion,
   enabled_solution: enabledSolution,
   enabled_notes: enabledNotes,
+  package_version: packageVersion,
   services,
   staging,
+  tuning_state: tuningState,
 } = saptuneStatusFactory.build();
 
 function ContainerWrapper({ children }) {

diff --git a/assets/js/components/SaptuneDetails/SaptuneDetails.test.jsx b/assets/js/components/SaptuneDetails/SaptuneDetails.test.jsx
@@ -10,19 +10,31 @@ import SaptuneDetails from './SaptuneDetails';
 describe('SaptuneDetails', () => {
   it('should render the details correctly', () => {
     const {
+      applied_notes: appliedNotes,
+      applied_solution: appliedSolution,
       configured_version: configuredVersion,
+      enabled_solution: enabledSolution,
+      enabled_notes: enabledNotes,
       package_version: packageVersion,
+      services,
+      staging,
       tuning_state: tuningState,
     } = saptuneStatusFactory.build();
 
     const { hostname, id: hostID } = hostFactory.build();
 
     renderWithRouter(
       <SaptuneDetails
-        packageVersion={packageVersion}
+        appliedNotes={appliedNotes}
+        appliedSolution={appliedSolution}
+        configuredVersion={configuredVersion}
+        enabledNotes={enabledNotes}
+        enabledSolution={enabledSolution}
         hostname={hostname}
         hostID={hostID}
-        configuredVersion={configuredVersion}
+        packageVersion={packageVersion}
+        services={services}
+        staging={staging}
         tuningState={tuningState}
       />
     );

diff --git a/assets/js/lib/test-utils/factories/hosts.js b/assets/js/lib/test-utils/factories/hosts.js
@@ -55,6 +55,9 @@ const saptuneServiceEnabledEnum = () =>
 const saptuneServiceNameEnum = () =>
   faker.helpers.arrayElement(['tuned', 'sapconf', 'saptune']);
 
+const saptuneSolutionNameEnum = () =>
+  faker.helpers.arrayElement(['NETWEAVER', 'HANA', 'NETWEAVER+HANA']);
+
 const saptuneServiceFactory = Factory.define(() => ({
   active: saptuneServiceActiveEnum(),
   enabled: saptuneServiceEnabledEnum(),
@@ -63,8 +66,8 @@ const saptuneServiceFactory = Factory.define(() => ({
 
 const saptuneStagingFactory = Factory.define(() => ({
   enabled: faker.datatype.boolean(),
-  notes: [],
-  solutions_ids: [],
+  notes: saptuneNotesIDs,
+  solutions_ids: saptuneNotesIDs,
 }));
 
 const saptuneAppliedNotesFactory = Factory.define(() => ({
@@ -74,7 +77,7 @@ const saptuneAppliedNotesFactory = Factory.define(() => ({
 
 const saptuneAppliedSolutionFactory = Factory.define(() => ({
   notes: saptuneNotesIDs.map((id) => id),
-  id: 'NETWEAVER',
+  id: saptuneSolutionNameEnum(),
   partial: faker.datatype.boolean(),
 }));
 
@@ -84,7 +87,7 @@ const saptuneEnabledNotesFactory = Factory.define(() => ({
 }));
 
 const saptuneEnabledSolutionsFactory = Factory.define(() => ({
-  id: 'NETWEAVER',
+  id: saptuneSolutionNameEnum(),
   notes: saptuneNotesIDs.map((id) => id),
   partial: faker.datatype.boolean(),
 }));