Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable link to unavailable pacemaker cluster detail in home/health summary #1007

Merged
merged 1 commit into from Nov 25, 2022

Conversation

nelsonkopliku
Copy link
Member

Description

This PR disables links to pacemaker cluster in the dashboard when a pacemaker cluster is not available.

no-cluster-link

How was this tested?

An additional jest test was added and it was tested manually against the scenario provided by Alberto.

Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Nelson, looks good but just a question: shouldn't it also have another test for when the link needs to be there?

@CDimonaco
Copy link
Member

I think we have the "core" functionality right here, but the hovering animation is still present, I think we should disable the hover transition and the pointer events, so that the item can completely act as a "non button", what do you think? Tag @jagabomb for further UI insights 👁️

@nelsonkopliku nelsonkopliku force-pushed the fix_broken_link_to_cluster branch 3 times, most recently from 6a30ada to 31b90a2 Compare November 23, 2022 21:19
@nelsonkopliku
Copy link
Member Author

I think we have the "core" functionality right here, but the hovering animation is still present, I think we should disable the hover transition and the pointer events, so that the item can completely act as a "non button"

hey @CDimonaco I agree with you, the fact is that to me it seems to be already behaving that way 😄

The hovering animation you are referring to is bound to HealthIcon component, and by disabling pointerEvents on the outer Link, those are not propagated to the contained icon and there is no hovering.

This is at least what I can observe when running it locally and in the attached gif

What am I missing?

@nelsonkopliku nelsonkopliku force-pushed the fix_broken_link_to_cluster branch 2 times, most recently from 7cd7586 to e291fcf Compare November 24, 2022 12:05
@nelsonkopliku nelsonkopliku force-pushed the fix_broken_link_to_cluster branch 2 times, most recently from 5a60010 to 06d65fe Compare November 24, 2022 14:11
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

assets/js/components/Health/HealthIcon.jsx Show resolved Hide resolved
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for applying the changes 👍

@nelsonkopliku nelsonkopliku merged commit da59ad7 into main Nov 25, 2022
@nelsonkopliku nelsonkopliku deleted the fix_broken_link_to_cluster branch November 25, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

5 participants