New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable link to unavailable pacemaker cluster detail in home/health summary #1007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Nelson, looks good but just a question: shouldn't it also have another test for when the link needs to be there?
368426b
to
b6d5599
Compare
I think we have the "core" functionality right here, but the hovering animation is still present, I think we should disable the hover transition and the pointer events, so that the item can completely act as a "non button", what do you think? Tag @jagabomb for further UI insights 👁️ |
6a30ada
to
31b90a2
Compare
hey @CDimonaco I agree with you, the fact is that to me it seems to be already behaving that way 😄 The hovering animation you are referring to is bound to This is at least what I can observe when running it locally and in the attached gif What am I missing? |
31b90a2
to
e6ee689
Compare
7cd7586
to
e291fcf
Compare
5a60010
to
06d65fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
06d65fe
to
c2139b3
Compare
… when a cluster is not available
c2139b3
to
0b3b770
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for applying the changes 👍
Description
This PR disables links to pacemaker cluster in the dashboard when a pacemaker cluster is not available.
How was this tested?
An additional jest test was added and it was tested manually against the scenario provided by Alberto.