Transition start execution running #1056
Conversation
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
nelsonkopliku,
CDimonaco,
EMaksy and
jamie-suse
assets/js/components/TriggerChecksExecutionRequest/TriggerChecksExecutionRequest.test.jsx
Outdated
Show resolved
Hide resolved
| @@ -158,6 +158,7 @@ function ChecksSelectionNew({ clusterId, cluster }) { | |||
| {localSavingSuccess && selectedChecks.length > 0 && ( | |||
| <SuggestTriggeringChecksExecutionAfterSettingsUpdated | |||
| clusterId={clusterId} | |||
| usingWanda | |||
There was a problem hiding this comment.
Can we avoid referencing the raw name of the service? something like usingNewChecksEngine would be fine.
Also, we use the same pattern in the router. Having a shared name for all these props would allow us for a simpler grep in the future when we have to remove all of these switches.
There was a problem hiding this comment.
I replaced all the places where we have this pattern by this usingWanda, so there is not any other wording.
This variable will be removed soonish, and I preferred the wanda wording, as it makes it cristal clear what it does.
But well, I will check if you prefer the other way around
| export const executionRequested = (clusterID, hosts, checks) => ({ | ||
| type: EXECUTION_REQUESTED, | ||
| payload: { clusterID, hosts, checks }, | ||
| }); |
There was a problem hiding this comment.
Maybe just requestExecution?
There was a problem hiding this comment.
Let's avoid this discussion now. We already have a tech debt ticket to talk about present/past term in the actions/events, etc
arbulu89
force-pushed
the
transition-start-execution-running
branch
from
6406053
to
57a90f0
Compare
Add transition since the execution is started until it is received from wanda. It uses a "fake it until make it" pattern which fakes the redux state setting an execution in a running state.
Now on, all wanda related views are under
clusters_new/${clusterID}endpoint. This is done with theusingWandaboolean variablePD: I have fixed many small (and not so small) details on the way
PD2: The gif is a bit faked, as in order to work we need to merge #1032 first