Jest table filter tests on the overview pages #1212
Conversation
arbulu89
requested review from
CDimonaco,
rtorrero,
dottorblaster,
fabriziosestito and
nelsonkopliku
There was a problem hiding this comment.
Thanks for the huge contribution! Besides, I don't know if having the cypress tests ported as-they-are adds much value.
Also, I would like to have the removal of the cypress stuff in a subsequent PR.
About the testing of the filters inside the table test, I would like to test that purely without the router and the query string, and have the query-string-based test inside the overviews test, since it already requires the router wrapping. This way we can split the testing in two layers, one that is pure and one that tests the outcome in a more "e2e" fashion. These two layers will overlap a little but this way we increase coverage and robustness.
@CDimonaco what do you think?
There was a problem hiding this comment.
I totally agree with all the comments made by @dottorblaster.
I think we will gain much value by splitting this process in separate prs, one for the pure table filtering, in which we test the table component and all the configuration, the filtering and the pure interactions with that component, one for the "integration" in other views and one for the removal.
Anyway thanks for the contribution, I think that splitting and addressing the comments made gains a lot of value and makes the review process more easy
arbulu89
force-pushed
the
jest-table-filter-tests
branch
from
59ce766
to
47d06ce
Compare
arbulu89
force-pushed
the
jest-table-filter-tests
branch
from
47d06ce
to
7461657
Compare
|
@CDimonaco @dottorblaster The other PR rebased, so this one ready to review! |
arbulu89
changed the title
Description
Move tables filtering tests from cypress to jest. This makes the testing more reliable. Besides, now all filters are covered, and adding new scenarios is pretty simple.
The tests are pretty much identical across all the table views: hosts, clusters, sap systems and databases, but I have decided to add all of them. This is mainly because the filter function for each filter box is specific.
The code is based in scenario tables, which later on are used in the test. Even though the code looks similar, some duplication is better here, to avoid having more complex code.
The most generic table filtering tests are done in the specific
Table.test.jsxfile, as we don't really need specific tables and data for it. (Edit: now done in: #1216)Finally, it removes the cypress tests (Edit: now done in: #1215)