Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckResultsOverview story #1511

Merged
merged 3 commits into from Jun 13, 2023
Merged

Add CheckResultsOverview story #1511

merged 3 commits into from Jun 13, 2023

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Jun 9, 2023

Description

This pull request adds missing Storybook story for the ChecksResultOverview component.

##Demo
storybookDemo

Related PR

This pull request is related to PR #1510

How was this tested?

Test already in PR #1510

@EMaksy EMaksy added enhancement New feature or request javascript Pull requests that update Javascript code labels Jun 9, 2023
@EMaksy EMaksy self-assigned this Jun 9, 2023
@EMaksy EMaksy force-pushed the check_result_overview_story branch 5 times, most recently from 49c3715 to 83463e6 Compare June 12, 2023 09:35
@EMaksy EMaksy marked this pull request as ready for review June 12, 2023 12:27
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nitpick. Besides that LGTM

@EMaksy EMaksy force-pushed the check_result_overview_story branch 2 times, most recently from f64c901 to a9773ea Compare June 13, 2023 08:28
@EMaksy EMaksy merged commit 231cc00 into main Jun 13, 2023
17 of 18 checks passed
@EMaksy EMaksy deleted the check_result_overview_story branch June 13, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

None yet

4 participants