Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sap system link cluster details #1543

Merged
merged 3 commits into from Jun 20, 2023
Merged

Conversation

arbulu89
Copy link
Contributor

Description

Add link to the sap system/database from the cluster details view using the SID.

Have a look on storybook if you want to see if life

image
image

How was this tested?

Tested

@arbulu89 arbulu89 added the enhancement New feature or request label Jun 19, 2023
@arbulu89 arbulu89 marked this pull request as ready for review June 19, 2023 14:20
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I only have a doubt on the new component.

assets/js/components/ClusterDetails/SapSystemLink.jsx Outdated Show resolved Hide resolved
@arbulu89 arbulu89 force-pushed the sap-system-link-cluster-details branch from 674fc14 to 0972be3 Compare June 19, 2023 15:19
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I'm that enthusiastic of this usage of link components as they spread our need for router-enabled tests and stories a lot, but I don't really see a viable alternative 😄

LGTM

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, LGTM :D

@arbulu89 arbulu89 merged commit 4d93d9f into main Jun 20, 2023
17 of 18 checks passed
@arbulu89 arbulu89 deleted the sap-system-link-cluster-details branch June 20, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

4 participants