Cluster settings page refactor #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
force-pushed
the
cluster-settings-page-aligned
branch
3 times, most recently
from
82e7002
to
9bc7e87
Compare
dottorblaster
force-pushed
the
cluster-settings-page-aligned
branch
from
e835e21
to
8c41278
Compare
nelsonkopliku
requested changes
Jul 26, 2023
| } = useSelector(getCatalog()); | ||
|
|
||
| if (!cluster) { | ||
| return <div>Loading...</div>; |
There was a problem hiding this comment.
For consistency we could use the LoadingBox component here
Suggested change
| return <div>Loading...</div>; | |
| return <LoadingBox text="Loading..." />; |
| return <div>Loading...</div>; | ||
| } | ||
|
|
||
| const { provider, type, selected_checks: selectedChecks } = cluster; |
There was a problem hiding this comment.
We could destructure clusterName here as well instead of using getClusterName function imported from ClusterLink on line 12. Wdyt?
dottorblaster
force-pushed
the
cluster-settings-page-aligned
branch
from
271634e
to
8141471
Compare
nelsonkopliku
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Remove old ChecksSelection UI * Rewrite ClusterSettingsPage * Wire up ClusterSettingsPage to the router
dottorblaster
added a commit
that referenced
this pull request
Aug 4, 2023
* Add navigation to host check selection (#1658) * Align cluster/host naming related to checks selection and actions * Add Checks related Call to actions in host detail * Host detail - Move exporters mapping to components in a separate variable * Cluster settings page refactor (#1659) * Remove old ChecksSelection UI * Rewrite ClusterSettingsPage * Wire up ClusterSettingsPage to the router * Make checks selection great again (#1682) * Add a new selector for cluster checks * Update ChecksSelection component to new UX * Update ClusterSettingsPage to new UX * Update Host Settings to new UX * Add a disabled prop to Button component * Align the behavior of the save checks button * fixup! Align the behavior of the save checks button * Improved tooltip (#1674) * Install react-tooltip * Add new Tooltipo component * Update Tooltip stories * Add a global css object for tests * Replace legacy tooltip with new one * Use spans as tooltip anchor wrapper * Replace react-tooltip with rc-tooltip Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com> * Switch Tooltip implementation to rc-tooltip Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com> --------- Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com> --------- Co-authored-by: Alessio Biancalana <alessio.biancalana@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now the cluster settings page uses the new
ChecksSelectionvisual component.How was this tested?
Automated tests migrated