Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host checks execution api #1740

Merged
merged 5 commits into from Aug 29, 2023
Merged

Host checks execution api #1740

merged 5 commits into from Aug 29, 2023

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Aug 23, 2023 •
edited

Description

Disclaimer: don't be scared, mainly tests

This PR exposes a new endpoint to request checks execution for a host.

  • an execution can be started only for registered hosts
  • an execution can be started only for non empty selections (cluster endpoint needs to be fixed about this)
  • target type is provided to the ExecutionRequested message
  • target type is handled on ExecutionStarted and ExecutionCompleted
  • unsupported target types are handled

How was this tested?

Automated tests ajdusted/added plus manual test in integration with wanda.

@nelsonkopliku nelsonkopliku added the enhancement New feature or request label Aug 24, 2023
@nelsonkopliku nelsonkopliku force-pushed the host_checks_execution_api branch 8 times, most recently from bea6a7c to ab27ade Compare August 25, 2023 08:43
@nelsonkopliku nelsonkopliku added user story elixir Pull requests that update Elixir code labels Aug 25, 2023
nelsonkopliku and others added 5 commits August 25, 2023 12:45
@nelsonkopliku @EMaksy
Add support for both cluster and host checks execution in Checks Engi…
96f8170 
…ne integration module

Co-authored-by: Eugen Maksymenko <eugen.maksymenko@suse.com>
@nelsonkopliku @EMaksy
Add a request checks execution feature to Hosts, adjust Clusters
f7b7146 
Co-authored-by: Eugen Maksymenko <eugen.maksymenko@suse.com>
@nelsonkopliku @EMaksy
Handle different target types in message processor
ac8c112 
Co-authored-by: Eugen Maksymenko <eugen.maksymenko@suse.com>
@nelsonkopliku @EMaksy
Add an endpoint to request checks execution for a host
fb9d80b 
Co-authored-by: Eugen Maksymenko <eugen.maksymenko@suse.com>
@nelsonkopliku
Add HostChecksSelected to roll up
b86be04
@nelsonkopliku nelsonkopliku marked this pull request as ready for review August 25, 2023 10:47
dottorblaster
dottorblaster approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EMaksy
EMaksy approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man great stuff, a big thanks!
Just some small questions as comments, but besides this nothing to add!
LGTM! 👍

lib/trento/application/integration/checks/checks.ex Show resolved Hide resolved
lib/trento/application/integration/checks/checks.ex Show resolved Hide resolved
@nelsonkopliku nelsonkopliku merged commit 9ed46e9 into main Aug 29, 2023
24 checks passed
@nelsonkopliku nelsonkopliku deleted the host_checks_execution_api branch August 29, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@EMaksy EMaksy EMaksy approved these changes

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

Assignees

@nelsonkopliku nelsonkopliku

@EMaksy EMaksy

Labels
elixir Pull requests that update Elixir code enhancement New feature or request user story
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nelsonkopliku @dottorblaster @EMaksy