Saptune summary frontend #1796
Merged
Saptune summary frontend #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
commented
Sep 7, 2023
| ]} | ||
| /> | ||
| </div> | ||
| <div className="mt-4 bg-white shadow rounded-lg py-4 xl:w-1/4"> |
There was a problem hiding this comment.
@dottorblaster @nelsonkopliku I guess we will need to have some checksAvailable kind of variable to decide if we put this coming soon or the results box.
There was a problem hiding this comment.
I guess, so. We'll be working on that soon.
| provider={host.provider} | ||
| providerData={host.provider_data} | ||
| sapInstances={sapInstances} | ||
| saptuneStatus={{}} |
arbulu89
force-pushed
the
saptune-summary-frontend
branch
from
d2b73f3
to
feae09d
Compare
arbulu89
force-pushed
the
saptune-summary-frontend
branch
from
feae09d
to
e9ba4ee
Compare
|
@arbulu89 I see that you have assigned this to me. The storybooks look good. Is there anything else that you would like me to do here? |
I wanted to put you in the list of review... 😅 |
arbulu89
commented
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add saptune summary box to HostDetails view. I have put some of the elements inside
SaptuneDetails, as the will be used there, once we have that component. It looks the more appropriate place.The used "struct" of
saptuneStatusis temporal. It will be similar, we might need to change it once we exactly know how the redux store will be composed.Storybook (in real execution the fields are like
Not installed):How was this tested?
Tested and stories added.