Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltip texts #1979

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Update tooltip texts #1979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f57cc
Update sap link tooltip text
arbulu89 Nov 7, 2023
a8609a0
Update sap instance not registered tooltip text
arbulu89 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/js/components/InstanceOverview/InstanceOverview.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function InstanceOverview({
<div className={rowClasses}>
<div className="table-cell p-2 px-5 align-center">
<Tooltip
content="Instance currently not found."
content="Registered instance not found."
place="bottom"
isEnabled={!!absentAt}
>
Expand Down
2 changes: 1 addition & 1 deletion assets/js/components/InstanceOverview/InstanceOverview.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('InstanceOverview', () => {
expect(screen.queryByRole('button', { name: 'Clean up' })).toBeVisible();
await act(async () => user.hover(healthIcon));
await waitFor(() =>
expect(screen.queryByText('Instance currently not found.')).toBeVisible()
expect(screen.queryByText('Registered instance not found.')).toBeVisible()
);
});

Expand Down
2 changes: 1 addition & 1 deletion assets/js/components/SapSystemLink.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function SapSystemLink({ systemType, sapSystemId, children }) {
{children}
</Link>
) : (
<Tooltip content="SAP System currently not registered." place="bottom">
<Tooltip content="System currently not registered." place="bottom">
<span className="group flex items-center relative">
<EOS_WARNING_OUTLINED
size="base"
Expand Down
2 changes: 1 addition & 1 deletion assets/js/components/SapSystemLink.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('SapSystemLink', () => {
await act(async () => user.hover(sidElement));

expect(
screen.getByText('SAP System currently not registered.')
screen.getByText('System currently not registered.')
).toBeInTheDocument();
});
});