Use databasesList slice properly to get db instances #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
fix-database-instances-selector
branch
from
45f6ba4
to
789564a
Compare
dottorblaster
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes 2 selectors which uses the
sapSystemsslice incorrectly to get data ofdatabasesListslice.This creates the situation that if the SAP system using the database is deregistered, the database instances are not returned anymore, leaving "empty" HANA database (without instances).
I have checked, and as far as I could test, it doesn't have any "not wanted" side-effect
How was this tested?
Tests updated. I did some manual testing as well.