Iconify check's target type in catalog #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
enhancement
nelsonkopliku
changed the title
nelsonkopliku
force-pushed
the
iconify-checks-in-catalog
branch
from
40e19ca
to
4f480c5
Compare
nelsonkopliku
force-pushed
the
iconify-checks-in-catalog
branch
from
ae11ce4
to
1d80bb3
Compare
jamie-suse
approved these changes
Nov 15, 2023
dottorblaster
requested changes
Nov 15, 2023
dottorblaster
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an icon to the checks catalog representing the target type: currently
hostorcluster.It gracefully handles cases where there might not be a target type metadata for a check (even though I am not sure it should ever happen)
How was this tested?
Automated test + storybooks