Reorganize directory structure for clusters context #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtorrero
force-pushed
the
clusters-context
branch
2 times, most recently
from
5a152bc
to
d174981
Compare
arbulu89
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Hey @rtorrero
2 things.
- Try to put
Clustersaliases beforeHostsaliases, to have a correct alphabetical order - I think your formatter is broken somehow, as it is adding parenthesis to many
fieldentries, which we shouldn't have
lib/trento/application/event_handlers/stream_roll_up_event_handler.ex
Outdated
Show resolved
Hide resolved
arbulu89
requested changes
Nov 23, 2023
test/trento/application/integration/discovery/protocol/enrich_register_cluster_host_test.exs
Outdated
Show resolved
Hide resolved
rtorrero
force-pushed
the
clusters-context
branch
from
f7ead11
to
2dbb8d2
Compare
arbulu89
approved these changes
Nov 24, 2023
| @@ -7,7 +7,11 @@ defmodule Trento.ClustersTest do | |||
|
|
|||
| import Trento.Factory | |||
|
|
|||
| alias Trento.{ClusterEnrichmentData, ClusterReadModel, Clusters} | |||
| alias Trento.Clusters | |||
There was a problem hiding this comment.
Move this file to test/trento/clusters_test.exs
| @@ -1,11 +1,11 @@ | |||
| defmodule Trento.ClusterTest do | |||
| use Trento.AggregateCase, aggregate: Trento.Domain.Cluster, async: true | |||
| use Trento.AggregateCase, aggregate: Trento.Clusters.Cluster, async: true | |||
There was a problem hiding this comment.
Move this file to test/trento/clusters/cluster_test.exs
test/trento/infrastructure/discovery/policies/cluster_policy_test.exs
Outdated
Show resolved
Hide resolved
rtorrero
force-pushed
the
clusters-context
branch
from
a9a1988
to
3abcf29
Compare
rtorrero
force-pushed
the
clusters-context
branch
from
3abcf29
to
66e68e5
Compare
CDimonaco
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the context-based reordering from ADR#10 for clusters