Generic selection component

[nelsonkopliku]

Description

Generalizes the current ProviderSelection to a Select which will be used also for other filters in the catalog.

How was this tested?

Test and storybook

[dottorblaster]

Good job but a Select component is not only used for filters, but for selects 😄

Could you do the whole composition about the all options on the outside layer?

[nelsonkopliku]

@dottorblaster good point thanks! At the end I decided to let the used define whether an All options option is wanted b1f8931

[dottorblaster]

Good job, just one thing to adjust. This way we could reuse this component as a generic select in the future and not only as a filter. That's why I asked you to move out the whole "all" logic outside of the component to increase the chance for composition.

[dottorblaster]

Suggested change

	options={PROVIDERS}
	withAllOption
	options={[ALL_OPTION, ...PROVIDERS]}

[nelsonkopliku]

we could reuse this component as a generic select in the future and not only as a filter.

We can already do this, even with the withAllOption prop, right?

[nelsonkopliku]

@dottorblaster heres the last two commits 8e02b2a and 40ed6f0

[dottorblaster]

Great! Thanks!

[nelsonkopliku]

@dottorblaster in total honesty I was confused by the whole "all" logic outside 😅
I mean, we still have in the component the logic to handle how to render an all. We just changed how we add an all option to the options.

Anyway, thanks for the review!