Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remaining leftovers #2026

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Refactor remaining leftovers #2026

merged 6 commits into from
Nov 27, 2023

Conversation

arbulu89
Copy link
Contributor

Description

Refactor remaining leftovers:

  • Enums to main lib folder
  • Services to main lib folder
  • Some value objects that were forgotten to the correct context
  • Alerting to infrastructure

How was this tested?

Nothing new to be tested

@arbulu89 arbulu89 added the enhancement New feature or request label Nov 23, 2023
@CDimonaco CDimonaco self-requested a review November 23, 2023 13:57
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Hope the tests on alerting are covering the change in the template directory

@arbulu89 arbulu89 marked this pull request as ready for review November 27, 2023 09:48
@arbulu89 arbulu89 merged commit 403b617 into main Nov 27, 2023
26 checks passed
@arbulu89 arbulu89 deleted the refactor-remaining-leftovers branch November 27, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants