Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context extraction from infra #2027

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Context extraction from infra #2027

merged 5 commits into from
Nov 27, 2023

Conversation

CDimonaco
Copy link
Member

Description

Extracting installation and discovery as dedicated contexts from infrastructure.

Installation renamed to settings.

How was this tested?

Moved tests

@CDimonaco CDimonaco added enhancement New feature or request chore labels Nov 23, 2023
@CDimonaco CDimonaco self-assigned this Nov 23, 2023
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection!

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only one comment.

lib/trento_web/controllers/v1/installation_controller.ex Outdated Show resolved Hide resolved
@arbulu89 arbulu89 force-pushed the context_extraction_from_infra branch from 6f7100f to c4bf964 Compare November 27, 2023 12:22
@arbulu89 arbulu89 marked this pull request as ready for review November 27, 2023 12:22
@arbulu89 arbulu89 merged commit 74783ca into main Nov 27, 2023
26 checks passed
@arbulu89 arbulu89 deleted the context_extraction_from_infra branch November 27, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants