Refactor to createOptionRenderer helper #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
commented
Nov 27, 2023
Comment on lines
+19
to
+36
| const providerOptionRenderer = createOptionRenderer( | ||
| 'All providers', | ||
| (provider) => <ProviderLabel provider={provider} /> | ||
| ); | ||
| const targetTypeOptionRenderer = (targetType) => ( | ||
| <TargetIcon targetType={targetType} className="inline mr-2 h-4"> | ||
| {targetType === TARGET_CLUSTER && 'Clusters'} | ||
| {targetType === TARGET_HOST && 'Hosts'} | ||
| </TargetIcon> | ||
|
|
||
| const clusterTypeRenderer = createOptionRenderer( | ||
| 'All cluster types', | ||
| getClusterTypeLabel | ||
| ); | ||
|
|
||
| const targetTypeOptionRenderer = createOptionRenderer( | ||
| 'All targets', | ||
| (targetType) => ( | ||
| <TargetIcon targetType={targetType} className="inline mr-2 h-4"> | ||
| {targetType === TARGET_CLUSTER && 'Clusters'} | ||
| {targetType === TARGET_HOST && 'Hosts'} | ||
| </TargetIcon> | ||
| ) |
There was a problem hiding this comment.
Maybe it would make sense to move these to a separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
createOptionRendererto the Select component to encapsulate theallhandling logicHow was this tested?
Jest tests updated 馃憤