Improved catalog filtering #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
enhancement
nelsonkopliku
force-pushed
the
improved-catalog-filtering
branch
from
c79b24a
to
1610399
Compare
nelsonkopliku
force-pushed
the
improved-catalog-filtering
branch
from
1610399
to
4560f92
Compare
nelsonkopliku
force-pushed
the
improved-catalog-filtering
branch
4 times, most recently
from
089dd43
to
b661f64
Compare
dottorblaster
requested changes
Nov 29, 2023
nelsonkopliku
force-pushed
the
improved-catalog-filtering
branch
from
b661f64
to
7def41a
Compare
nelsonkopliku
force-pushed
the
improved-catalog-filtering
branch
from
7def41a
to
1a42780
Compare
|
Thanks @dottorblaster. Addressed the feedbacks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the possibility to feed the
Selectcomponent with a list of objects as options, where thevalueanddisabledproperties can be defined.As a result disabled options can also be handled.
Currently unsupported filters have been disabled (target type host and cluster type hana scale out and ascs/ers)
Enabling disabled options needs a pr to do so.
Further automatism to rely on the catalog to determine enabled/disabled options needs further refactoring on the catalog state. Tracking an item in the backlog
How was this tested?
Automated tests/storybook.
https://2035.prenv.trento.suse.com/catalog
Catalog Story
Select Story