Refactor React components directory structure #2037
Conversation
EMaksy
force-pushed
the
refactor_components_dir
branch
7 times, most recently
from
c184539
to
0f23efd
Compare
EMaksy
changed the title
EMaksy
force-pushed
the
refactor_components_dir
branch
3 times, most recently
from
8e4de99
to
91132c6
Compare
EMaksy
requested review from
arbulu89,
nelsonkopliku,
CDimonaco,
dottorblaster,
rtorrero and
jamie-suse
and removed request for
nelsonkopliku
EMaksy
force-pushed
the
refactor_components_dir
branch
from
91132c6
to
ba96331
Compare
| import { ClusterInfoBox } from '@components/ClusterDetails'; | ||
| import HostInfoBox from '@components/HostDetails/HostInfoBox'; | ||
| import { ClusterInfoBox } from '@pages/ClusterDetails'; | ||
| import HostInfoBox from '@pages/HostSettingsPage/HostInfoBox'; |
There was a problem hiding this comment.
I see here we borrow HostInfoBox from HostSettingsPage; going by our new structure, shouldn't we move HostInfoBox into the commmon/ directory then?
(Though this may not be for this PR)
There was a problem hiding this comment.
(similar for ClusterInfoBox)
There was a problem hiding this comment.
I think you're right @jamie-suse but I wouldn't follow through that in this PR 👍
There was a problem hiding this comment.
I see there also opportunities to refactor some places, but i would not mind to split it up in a follow up pr :)
EMaksy
force-pushed
the
refactor_components_dir
branch
from
ba96331
to
dd825e0
Compare
There was a problem hiding this comment.
I wouldn't follow through actual individual component refactoring through this PR but at the moment the state looks good.
@CDimonaco I would leave to you the final call about this 👍
EMaksy
force-pushed
the
refactor_components_dir
branch
from
dd825e0
to
3ffa1a1
Compare
EMaksy
force-pushed
the
refactor_components_dir
branch
2 times, most recently
from
7538d51
to
b23a8a9
Compare
EMaksy
force-pushed
the
refactor_components_dir
branch
from
c41e108
to
68cd052
Compare
Description
This PR implements directory restructuring based on ADR 009. It separates the components directory into 'common' and 'pages,' enhancing code organization. The change ensures better reuse of common components across multiple pages.
Result after the refactor:
