Charts Without Grafana #2049
Merged
Charts Without Grafana #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
added
enhancement
CDimonaco
force-pushed
the
charts_without_grafana
branch
2 times, most recently
from
532f165
to
73f0065
Compare
CDimonaco
requested review from
jamie-suse,
dottorblaster,
rtorrero and
EMaksy
and removed request for
jamie-suse
dottorblaster
approved these changes
Dec 21, 2023
| ], | ||
| })); | ||
|
|
||
| console.log('zoom level', chartJsInstance.getZoomLevel()); |
There was a problem hiding this comment.
I think we can use actions for these instead of console logging
CDimonaco
force-pushed
the
charts_without_grafana
branch
from
66ea310
to
24dfda5
Compare
rtorrero
reviewed
Dec 21, 2023
EMaksy
reviewed
Dec 21, 2023
EMaksy
reviewed
Dec 21, 2023
EMaksy
reviewed
Dec 21, 2023
EMaksy
reviewed
Dec 22, 2023
assets/js/common/TimeSeriesLineChart/TimeSeriesLineChart.test.jsx
Outdated
Show resolved
Hide resolved
EMaksy
reviewed
Dec 22, 2023
assets/js/common/TimeSeriesLineChart/TimeSeriesLineChart.test.jsx
Outdated
Show resolved
Hide resolved
EMaksy
reviewed
Dec 22, 2023
EMaksy
reviewed
Dec 22, 2023
EMaksy
reviewed
Dec 22, 2023
EMaksy
reviewed
Dec 22, 2023
EMaksy
reviewed
Dec 22, 2023
EMaksy
reviewed
Dec 22, 2023
EMaksy
reviewed
Dec 22, 2023
EMaksy
reviewed
Dec 22, 2023
CDimonaco
force-pushed
the
charts_without_grafana
branch
from
d630d0b
to
d7cb229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace Grafana charts using a bespoke implementation with Chart.js.
Grafana is completely removed, the backend will expose chart data through a dedicated endpoint.
The chart data is retrieved through prometheus.
How was this tested?
Automated tests