Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated target health does not take into account checks selection status #2050

Merged
merged 7 commits into from
Dec 1, 2023

Conversation

jamie-suse
Copy link
Contributor

Description

This changes how the aggregated health works for hosts and clusters.

  • Selected checks are no longer taken into account in the aggregated health calculation.
  • If the checks' health is :unknown, it is not taken into account.

How was this tested?

Added unit tests.

@jamie-suse jamie-suse added enhancement New feature or request elixir Pull requests that update Elixir code labels Nov 30, 2023
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from what Nelson already commented nothing to add, the change is straightforward. Good job!

@jamie-suse jamie-suse merged commit a41b636 into main Dec 1, 2023
26 checks passed
@jamie-suse jamie-suse deleted the health branch December 1, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants