Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: improve error message #2141

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

isimluk
Copy link
Contributor

@isimluk isimluk commented Jan 4, 2024

The error message needs to be more generic as various time series may flow through here.

The error message needs to be more generic as various time series may flow through here.
@CDimonaco CDimonaco self-requested a review January 4, 2024 14:01
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

LGTM for me, the ci is failing for a chromatic issue not related to codebase.

@dottorblaster
Copy link
Contributor

The red is just related to Chromatic's token not being present in the fork, nothing alarming. We can merge.

@dottorblaster dottorblaster merged commit 2b42fd1 into trento-project:main Jan 4, 2024
24 of 25 checks passed
@isimluk isimluk deleted the patch-1 branch January 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants