Fix ENSA version computation run only over application instances #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
changed the title
dottorblaster
force-pushed
the
fix-ensa-version-discovery
branch
from
ee12da7
to
3798024
Compare
nelsonkopliku
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
The fix looks good to me, thanks for addressing it 👍
I guess we can get this merged and follow up on:
- ensa version not being sent in the checks selection of an ascs/ers cluster
- ascs/ers information being sent also for hana clusters, where are not necessary
both related to what commented here #2126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing ENSA version computation for ASCS/ERS clusters: we only need to take into account application instances
How was this tested?
Existing unit tests modified