Remove Reset Filters button in Checks selection #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
enhancement
nelsonkopliku
changed the title
nelsonkopliku
force-pushed
the
no-reset-filter-empty-catalog
branch
from
45fc098
to
8c53944
Compare
dottorblaster
requested changes
Jan 9, 2024
nelsonkopliku
force-pushed
the
no-reset-filter-empty-catalog
branch
from
8c53944
to
d8a5aa0
Compare
nelsonkopliku
force-pushed
the
no-reset-filter-empty-catalog
branch
from
d8a5aa0
to
a2a65ec
Compare
dottorblaster
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to decide whether the
CatalogContainercomponent should also show aReset Filtersbutton when an empty catalog is detected.Needed to be able to have that reset filter in the catalog page, but not in the checks selection.
How was this tested?
Test added. Outdated storybooks fixed.
https://2154.prenv.trento.suse.com/clusters/0eac831a-aa66-5f45-89a4-007fbd2c5714/settings
Stories
https://643fc66e9747e47344899b8c-dbrfuwanza.chromatic.com/?path=/story/layouts-checkscatalog--empty
https://643fc66e9747e47344899b8c-dbrfuwanza.chromatic.com/?path=/story/patterns-checksselection--empty