Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new cert variables required by the ansible playbook #2162

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

rtorrero
Copy link
Contributor

Description

This PR adds the new certificate variables required by the changes in the ansible playbook from this PR: https://github.com/trento-project/ansible/pull/12/files

How was this tested?

Testing it here by adding the env tag

@rtorrero rtorrero added ci env Create an ephimeral environment for the pr branch labels Jan 10, 2024
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@rtorrero rtorrero merged commit 0e33088 into main Jan 12, 2024
34 checks passed
@rtorrero rtorrero deleted the add-cert-to-prenv branch January 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci env Create an ephimeral environment for the pr branch
Development

Successfully merging this pull request may close these issues.

None yet

5 participants