Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose utility adapt #2184

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Docker compose utility adapt #2184

merged 1 commit into from
Jan 16, 2024

Conversation

CDimonaco
Copy link
Member

Description

Adapt the new docker compose utility dns naming, we use it only in the prometheus config.

From this PR, the docker-compose version 1 utility is NOT SUPPORTED.

How was this tested?

Automated tests

@CDimonaco CDimonaco self-assigned this Jan 16, 2024
@CDimonaco CDimonaco changed the title Prometheus dev config adapted to docker compose utility dns naming Docker compose utility adapt Jan 16, 2024
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allright!
I guess I need to update it 🥲

@CDimonaco CDimonaco merged commit 028b721 into main Jan 16, 2024
30 checks passed
@CDimonaco CDimonaco deleted the docker_compose_v2_adapt branch January 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants