Saptune summary warning icon

[EMaksy]

Description

Add a warning state icon to the saptune overview when no saptune version is provided and sap workload is happening on the host

Left on host with sap workload and right without.
Preview:

How was this tested?

Updated existing good test to check if the icon was rendered.

[arbulu89]

Hey @EMaksy ,
Did you discuss the scenario where nodes without saptune will display this as well with @abravosuse ?
I mean, in that scenario, the host health is not changed to warning, and I think, this story comes from the need to reflect the warning point in the details view when the host list shows a warning health

[abravosuse]

@EMaksy just to clarify the discussion we had on Friday:

Right now, when a version of saptune lower than 3.1.0 is detected in a host, a warning icon is displayed in the corresponding details view, regardless whether there is an SAP workload or not. But only in the case there is such workload, the warning gets added to the aggregated health of the host.

The behavior should be the same when no saptune is detected:

• a warning icon is displayed in the corresponding details view, regardless whether there is an SAP workload or not.
• But only in the case there is such workload, the warning gets added to the aggregated health of the host

[EMaksy]

Thanks guys, for clarifying, I will ensure that it behaves like @abravosuse describes it 👍

[arbulu89]

@abravosuse @EMaksy if this is the case, i think the code might be ok.
Anyway, i'm surprised of this desired behaviour. Showing a warning icon if saptune is not installed in a host that doesn't need saptune doesn't look really appropriate for me. Specially because the host health is not affected by it.
My 2 cents.

[abravosuse]

@EMaksy apologies for the back and forth. Xabi has a point. Please scratch what I said before and go for the following behavior:

• a warning icon is displayed in the corresponding details view only if there is an SAP workload in the host
• in that case, the warning is added to the aggregated health of the host (this last part is already implemented!)

[arbulu89]

Good!
I think it makes the job

[arbulu89]

Not the most beautiful piece of code, but I guess it works

[CDimonaco]

LGTM for me,

As a suggestion, I reccomend to change the name of props from isSapPresent to sapPresent.

[rtorrero]

LGTM thanks @EMaksy