Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elixir upgrade dockerfiles #2196

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Elixir upgrade dockerfiles #2196

merged 2 commits into from
Jan 22, 2024

Conversation

arbulu89
Copy link
Contributor

Description

Update dockerfiles to work with elixir 1.15.7.

  • The community goes with tumbleweed, as it is the unique version which includes the needed elixir/erlang versions
  • The sles one needs those additional mix values to identify the needed utilities properly

How was this tested?

Manually

@arbulu89 arbulu89 added the enhancement New feature or request label Jan 18, 2024
@arbulu89 arbulu89 marked this pull request as ready for review January 18, 2024 16:01
dottorblaster
dottorblaster approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no problems so far

EMaksy
EMaksy approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbulu89 arbulu89 merged commit 4d0cd15 into main Jan 22, 2024
28 checks passed
@arbulu89 arbulu89 deleted the elixir-upgrade-dockerfiles branch January 22, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@CDimonaco CDimonaco CDimonaco approved these changes

@EMaksy EMaksy EMaksy approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arbulu89 @dottorblaster @nelsonkopliku @CDimonaco @EMaksy