Update README, by adding more references to installation options #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
reviewed
Jan 23, 2024
README.md
Outdated
|
|
||
| For manual instructions on installing Trento, please refer to our [Installation of Trento](https://github.com/trento-project/docs/blob/main/guides/manual-installation.md) guide. | ||
|
|
||
| ## Installing Trento using Ansible (WIP) |
There was a problem hiding this comment.
I would remove the WIP reference.
The ansible playbook is "finished" so to say.
README.md
Outdated
| @@ -71,6 +71,14 @@ See [related documentation](./guides/alerting/alerting.md) for more information. | |||
|
|
|||
| **Trento** can be installed in various ways, depending on your needs and the requirements of its different components. Please refer to the specific [Agent](https://github.com/trento-project/agent) documentation for more information. | |||
|
|
|||
| ## Installing Trento manually | |||
There was a problem hiding this comment.
I don't like the manually term.
What does it mean?
I would go simply with Installing Trento.
The same for the body of the chapter. `To install Trento, please refer to the
README.md
Outdated
| @@ -71,6 +71,14 @@ See [related documentation](./guides/alerting/alerting.md) for more information. | |||
|
|
|||
| **Trento** can be installed in various ways, depending on your needs and the requirements of its different components. Please refer to the specific [Agent](https://github.com/trento-project/agent) documentation for more information. | |||
|
|
|||
| ## Installing Trento manually | |||
|
|
|||
| For manual instructions on installing Trento, please refer to our [Installation of Trento](https://github.com/trento-project/docs/blob/main/guides/manual-installation.md) guide. | |||
There was a problem hiding this comment.
refer to our, i would remove our. please refer to the ... guide
EMaksy
force-pushed
the
update_readme_installation
branch
from
701561e
to
e46e22b
Compare
|
Thanks for the feedback, I adjusted and aligned all the installation options 👍 |
abravosuse
approved these changes
Jan 23, 2024
EMaksy
force-pushed
the
update_readme_installation
branch
2 times, most recently
from
e847969
to
4ae30a2
Compare
arbulu89
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As in the description, adding a reference to the manual installation guide and the Ansible repository in the installation section.