Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input fields #2213

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Input fields #2213

merged 7 commits into from
Jan 29, 2024

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Jan 23, 2024

Description

A bit of react verbosity 馃槃
Adds Components for input fields.
Based on https://github.com/react-component/input

How was this tested?

Automated tests, storybook.

@nelsonkopliku nelsonkopliku force-pushed the input-fields branch 2 times, most recently from 0d2e97d to ffabfac Compare January 24, 2024 15:37
@nelsonkopliku nelsonkopliku self-assigned this Jan 24, 2024
@nelsonkopliku nelsonkopliku added enhancement New feature or request ux javascript Pull requests that update Javascript code labels Jan 24, 2024
@nelsonkopliku nelsonkopliku marked this pull request as ready for review January 24, 2024 15:38
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things (mainly questions) but overall really great job, thank you so much 馃憤

assets/js/common/Input/Password.jsx Outdated Show resolved Hide resolved
assets/js/common/Input/Textarea.jsx Show resolved Hide resolved
@nelsonkopliku
Copy link
Member Author

@dottorblaster @jagabomb thanks for the feedback. Made the password togglable the default behavior.

@nelsonkopliku nelsonkopliku merged commit be7b055 into main Jan 29, 2024
23 checks passed
@nelsonkopliku nelsonkopliku deleted the input-fields branch January 29, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code ux
Development

Successfully merging this pull request may close these issues.

None yet

3 participants