-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hana scale out discovery #2220
Hana scale out discovery #2220
Conversation
a4a84b6
to
1c48638
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
83673d2
to
f7c041e
Compare
f7c041e
to
8941d83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey man could not find anything which does not look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @arbulu89, thanks!
Description
HANA scale out discovery.
We only need to change the policy.
In a scale out cluster how we identify different fields is different.
We need to find them in the
cluser_properties
field. Check the test fixtures to see them.The major difficulty comes when these attributes are not always present...
This depends on if some resource agents hooks are used or not...
As far as I discovered there are 3 ways:
unknown
value (I have not been able to get any fixture for this, so it is just a "I hope it works" effort)SAPHanaSR.py
hook. This is old hook. In this case we don't have thehana_<sid>_site_srHook_<site>
attributesSAPHanaSrMultiTarget.py
hook, which provides the latest fields.Now...
role
column needs to be redefined. This value issite
based instead of host based. In scale up it doesn't really matter to show it wrong, but we need a new design most probablySAPHanaSR health state
field is as well site based. Right now, we only show the secondary value, but we could show both sites in fact@abravosuse the topics above must be discussed (we already started some days ago in fact).
In a next PR I want to add some storybook story, add some E2E test just in case and upload a real scale out fixtures set.
This is how it looks like:
How was this tested?
Tested in the backend