Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hana scale out discovery #2220

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Hana scale out discovery #2220

merged 5 commits into from
Feb 7, 2024

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Jan 25, 2024

Description

HANA scale out discovery.
We only need to change the policy.
In a scale out cluster how we identify different fields is different.
We need to find them in the cluser_properties field. Check the test fixtures to see them.
The major difficulty comes when these attributes are not always present...
This depends on if some resource agents hooks are used or not...
As far as I discovered there are 3 ways:

  • No hooks. So the fields might not be there, so some fields will be populated with unknown value (I have not been able to get any fixture for this, so it is just a "I hope it works" effort)
  • SAPHanaSR.py hook. This is old hook. In this case we don't have the hana_<sid>_site_srHook_<site> attributes
  • SAPHanaSrMultiTarget.py hook, which provides the latest fields.

Now...

  • The value in nodes role column needs to be redefined. This value is site based instead of host based. In scale up it doesn't really matter to show it wrong, but we need a new design most probably
  • The SAPHanaSR health state field is as well site based. Right now, we only show the secondary value, but we could show both sites in fact
  • The majority maker nodes is not visualized

@abravosuse the topics above must be discussed (we already started some days ago in fact).

In a next PR I want to add some storybook story, add some E2E test just in case and upload a real scale out fixtures set.

This is how it looks like:
scale_out

How was this tested?

Tested in the backend

@arbulu89 arbulu89 added the enhancement New feature or request label Jan 25, 2024
Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost there @arbulu89 but, as discussed by Slack, maybe better to hold it until we have a final UI design. I will work on the ticket for @jagabomb tomorrow.

@arbulu89 arbulu89 marked this pull request as ready for review January 29, 2024 09:38
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man could not find anything which does not look good 👍

Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @arbulu89, thanks!

@arbulu89 arbulu89 merged commit faba29a into main Feb 7, 2024
23 checks passed
@arbulu89 arbulu89 deleted the hana-scale-out-discovery branch February 7, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

4 participants