Fix charts tests increasing prometheus retention time in dev docker compose #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
fix-charts-test-prometheus-retention
branch
from
9a2283b
to
1c4492c
Compare
|
Thanks for spotting that bug! |
CDimonaco
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix charts tests increasing prometheus retention time in dev docker compose.
Without this, the default retention time of 15 days was removing the samples coming in the snapshot.
Unfortunately, this is not 100% fix, as after 5 years, the tests might start failling again, but I didn't find anything better without changing completely how the tests are done.
Mocking the prometheus server could an option, but this would remove the real integration test that we do now with the current tests.
How was this tested?
Tested manually over some days