Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to retrieve software update settings #2250

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Conversation

jamie-suse
Copy link
Contributor

@jamie-suse jamie-suse commented Feb 1, 2024

Description

This change adds a HTTP endpoint GET /api/v1/user_settings to allow reading of user credentials to the SAP software update system (i.e. at time of writing, SUSE Manager).

How was this tested?

Added unit tests for new functions.

@jamie-suse jamie-suse added enhancement New feature or request elixir Pull requests that update Elixir code labels Feb 1, 2024
@jamie-suse jamie-suse force-pushed the suma-endpoints branch 9 times, most recently from 9577c7c to 1c5c1db Compare February 2, 2024 12:59
@jamie-suse jamie-suse changed the title Add software updates endpoints Add endpoint to retrieve software update settings Feb 2, 2024
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! A few comments though.

lib/trento_web/router.ex Outdated Show resolved Hide resolved
test/trento_web/views/v1/software_updates_view_test.exs Outdated Show resolved Hide resolved
test/trento_web/views/v1/software_updates_view_test.exs Outdated Show resolved Hide resolved
test/trento_web/views/v1/software_updates_view_test.exs Outdated Show resolved Hide resolved
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamie-suse jamie-suse merged commit b5293c2 into main Feb 6, 2024
23 checks passed
@jamie-suse jamie-suse deleted the suma-endpoints branch February 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants