Add RPM package generation #2258
Conversation
There was a problem hiding this comment.
Some suggestions:
- I think we need to use a normal
_servicefile to create the tarball and set the version to the spec file - I would move the container creation files to a
containersubfolder, as sibling of therpmfolder - I wouldn't name the env file
env_trento_web. I would name ittrento_web.exampleor similar. We want this being an example. The user must modify it.
packaging/suse/rpm/trento-web.spec
Outdated
| export MIX_HOME=/usr/bin | ||
| export MIX_REBAR3=/usr/bin/rebar3 | ||
| export MIX_PATH=/usr/lib/elixir/lib/hex/ebin | ||
| echo $LANG |
packaging/suse/rpm/trento-web.spec
Outdated
| install -D -m 0600 packaging/suse/rpm/systemd/env_trento_web %{buildroot}/etc/trento/env_trento_web | ||
|
|
||
| %post | ||
| %postun |
There was a problem hiding this comment.
Don't you need to add all the service_add_x pre/post entries?
%pre
%service_add_pre trento-web.service
%post
%service_add_post trento-web.service
%preun
%service_del_preun trento-web.service
%postun
%service_del_postun trento-web.service
packaging/suse/rpm/trento-web.spec
Outdated
| /etc/trento/env_trento_web | ||
|
|
||
| %license LICENSE | ||
| %doc CHANGELOG.md README.md |
There was a problem hiding this comment.
I don't think we need the CHANGELOG. It will came from the .changes file in %changelog.
In fact, i would add everything under the guide folder if possible
| @@ -0,0 +1,14 @@ | |||
| [Unit] | |||
| Description=Trento web service | |||
.github/workflows/ci.yaml
Outdated
| @@ -756,12 +766,12 @@ jobs: | |||
| VERSION=$(./hack/get_version_from_git.sh) | |||
| # "+" character is not allowed in OBS dockerfile version strings | |||
| VERSION=${VERSION//[+]/-} | |||
| sed -i 's~%%VERSION%%~'"${VERSION}"'~' packaging/suse/Dockerfile | |||
| sed -i 's~%%VERSION%%~'"${VERSION}"'~' $BUILD_STEPS_FILE | |||
There was a problem hiding this comment.
This looks a really bad practice. We should use the _service file to build the tarball and set the format.
It is the most common way of doing it.
Have a look on the agent spec file
.github/workflows/ci.yaml
Outdated
| runs-on: ubuntu-20.04 | ||
| if: github.event_name == 'release' || (github.event_name == 'push' && github.ref_name == 'main') || github.event_name == 'workflow_dispatch' | ||
| needs: [static-code-analysis, test, test-fe, test-e2e] | ||
| strategy: |
There was a problem hiding this comment.
I'm not sure if we should use the same strategy.
In the rpm package we should leverage the _service file usage, which makes the process a bit different
|
Setting it to draft temporarily as I test CI changes |
packaging/suse/rpm/trento-web.spec
Outdated
| # FIXME: Select a correct license from https://github.com/openSUSE/spec-cleaner#spdx-licenses | ||
| License: Apache-2.0 | ||
| URL: https://github.com/trento-project/web | ||
| Source: web.tar.gz |
There was a problem hiding this comment.
Does this work with the service file?
You should have ${name}-${version}.tar.gz or trento-web-${version}.tar.gz
Description
This PR adds RPM package generation on OBS in addition to the existing container image building. Note that it most likely will fail to build in OBS but after we set up the linking on IBS, there it should build correctly.
How was this tested?
Tested manually by commenting out the irrelevant parts of the CI, and leaving the relevant parts on a fork and on separate project/package in OBS. Linking for IBS was also tested.