Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saptune discovery payloads to the healthy clusters scenario #2265

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Feb 6, 2024

Description

Add saptune discovery payloads to the 27 nodes cluster scenario, so we have the data in the demo environment.

The types are saptune payloads are based on:

  • saptune not installed / without sap workload
    three vmiscsi hosts
  • saptune not installed / with sap workload
    vmhdbdev* and vmnwdev* hosts
  • saptune < 3.1.0 installed / wihtout sap workload
    vmdrbddev* and vmdrbdqas* hosts
  • saptune < 3.1.0 installed / with sap workload
    vmhdbqas* and vmnwqas* hosts 
  • saptune >= 3.1.0 installed / without sap worload
    vmdrbdprd* hosts
  • saptune >= 3.1.0 installed / with sap workload / tuning compliant
    vmhdbprd* hosts
  • saptune >= 3.1.0 installed / with sap workload / not tuning compliant
    vmnwprd* hosts

@abravosuse I'm afraid that the PR env is not the best way to test this, as it doesn't have the heartbeat, so the agent health status is not changed, so either you go host by host to see the saptune summary, or you trust my local tests
https://2265.prenv.trento.suse.com/

@arbulu89 arbulu89 added chore env Create an ephimeral environment for the pr branch labels Feb 6, 2024
@arbulu89 arbulu89 force-pushed the demo-saptune-discovery-payloads branch from 2028af8 to 3e096de Compare February 6, 2024 16:39
@arbulu89 arbulu89 force-pushed the demo-saptune-discovery-payloads branch from 4bb0950 to 9b1d00b Compare February 6, 2024 16:45
@arbulu89 arbulu89 marked this pull request as ready for review February 6, 2024 16:46
@arbulu89 arbulu89 force-pushed the demo-saptune-discovery-payloads branch from 9b1d00b to 4041433 Compare February 6, 2024 16:57
Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely trust your tests @arbulu89

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good! Thanks for taking care of all the data 👍

@arbulu89 arbulu89 merged commit 13ff4e5 into main Feb 12, 2024
23 checks passed
@arbulu89 arbulu89 deleted the demo-saptune-discovery-payloads branch February 12, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore env Create an ephimeral environment for the pr branch
Development

Successfully merging this pull request may close these issues.

None yet

4 participants