Add endpoint to save SUMA credentials #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
added
enhancement
jamie-suse
force-pushed
the
save-suma-settings
branch
2 times, most recently
from
01637d2
to
6a47488
Compare
jamie-suse
force-pushed
the
save-suma-settings
branch
from
6a47488
to
e7838f7
Compare
nelsonkopliku
requested changes
Feb 9, 2024
test/trento_web/controllers/v1/suma_credentials_controller_test.exs
Outdated
Show resolved
Hide resolved
test/trento_web/controllers/v1/suma_credentials_controller_test.exs
Outdated
Show resolved
Hide resolved
dottorblaster
requested changes
Feb 9, 2024
Comment on lines
43
to
44
| with {:ok, saved_settings} <- | ||
| body_params |> Map.from_struct() |> SoftwareUpdates.save_settings() do |
There was a problem hiding this comment.
Nitpick: just be careful with the pipes in with statements, they can become pretty unreadable fast (personal PTSD moment with that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds endpoint to save SUMA credentials.
Using this endpoint, (new) credentials can only be saved if there currently aren't existing saved credentials.
How was this tested?
Added unit tests