Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to clear SUMA credentials #2272

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

jamie-suse
Copy link
Contributor

@jamie-suse jamie-suse commented Feb 7, 2024

Description

Adds an endpoint to clear user settings for SUSE Manager.

Endpoint is idempotent - server returns 204 status regardless if user settings have been previously saved or not.

How was this tested?

Added unit tests.

@jamie-suse jamie-suse added enhancement New feature or request elixir Pull requests that update Elixir code labels Feb 7, 2024
@nelsonkopliku nelsonkopliku marked this pull request as ready for review February 8, 2024 16:23
@jamie-suse
Copy link
Contributor Author

I can't approve my own Pull Request but LGTM 😍 🚀

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change request then we can merge 👍

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku merged commit b4ecdb0 into main Feb 9, 2024
24 checks passed
@nelsonkopliku nelsonkopliku deleted the clear-suma-settings branch February 9, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants