Hana details sites frontend #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
hana-details-sites-frontend
branch
2 times, most recently
from
f103e6d
to
5184ef2
Compare
arbulu89
force-pushed
the
hana-details-sites-frontend
branch
from
5184ef2
to
8456651
Compare
arbulu89
requested review from
rtorrero,
EMaksy,
CDimonaco,
jagabomb and
abravosuse
abravosuse
approved these changes
Feb 12, 2024
EMaksy
approved these changes
Feb 13, 2024
| import AttributesDetails from './AttributesDetails'; | ||
| import ReplicationStatusPill from './ReplicationStatusPill'; | ||
|
|
||
| const getSiteHealth = (srHealthStatus) => { |
There was a problem hiding this comment.
What do you think about replacing switch case with object literal as an alternative?
const getSiteHealth = (srHealthStatus) => {
const healthStatus = {
'4': 'passing',
'1': 'critical',
};
return healthStatus[srHealthStatus] || 'unknown';
};
There was a problem hiding this comment.
Honestly, i prefer the switch/case 😝
EMaksy
reviewed
Feb 13, 2024
CDimonaco
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on: #2277
Pending to rebase it once it is merged
Implement the frontend part of the
sitesimprovement in the HANA details view.Check the new style in storybook.
Sneak peak:
@jagabomb I have only added the table header with its object in this PR. Changing the bottom rounded style, details button, new columns, etc are not implemented here.
How was this tested?
Tested with UT, e2e and storybook