Cluster maintenance mode #2297
Cluster maintenance mode #2297
Conversation
CDimonaco
added
enhancement
There was a problem hiding this comment.
Looks good.
Some suggestions from my side.
Anyway, when I say maintenance state in the frontend instead of maintenance mode my brain almost exploded XD
Fix the factory at least, the tests are passing my merge coincidence, because you get false by default with lodash in the code
|
Thx for spotting all the stuff, everything is fixed, re-request review! |
CDimonaco
force-pushed
the
cluster_maintenance_mode
branch
from
986fa14
to
7b888ee
Compare
There was a problem hiding this comment.
Thank you @CDimonaco
All good from my side.
I did some tiny comments, but feel free to merge without a new review
| @@ -67,6 +67,7 @@ export const hanaClusterDetailsFactory = Factory.define(() => { | |||
| stopped_resources: clusterResourceFactory.buildList(2), | |||
| system_replication_mode: 'sync', | |||
| system_replication_operation_mode: 'logreplay', | |||
| maintenance_mode: false, | |||
There was a problem hiding this comment.
By the way, we should include this maintenance_mode entry in the ascsErsClusterDetailsFactory as well
| @@ -74,11 +74,11 @@ context('HANA cluster details', () => { | |||
| .contains(availableHanaCluster.hanaSecondarySyncState); | |||
| }); | |||
|
|
|||
| it(`should have sap hana sr health state ${availableHanaCluster.sapHanaSRHealthState}`, () => { | |||
| it(`should have maintenance mode ${availableHanaCluster.maintenanceState}`, () => { | |||
There was a problem hiding this comment.
I still see maintenanceState here 🙈
CDimonaco
force-pushed
the
cluster_maintenance_mode
branch
from
7b888ee
to
0617d37
Compare
|
Everything done! Thx for the feedbacks, merging when ci is green |
Description
Cluster maintenance mode.
Available for scale up, scale out and ascs/ers
We get the information through the
cibadmincommand.How was this tested?
Automated tests, backend, frontend and e2e