Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover diskless SBD clusters #2308

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Discover diskless SBD clusters #2308

merged 2 commits into from
Feb 15, 2024

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Feb 14, 2024 •
edited

Description

Discover diskless SBD clusters.
A diskless SBD consists of:

  • There is not any fencing resource configured
  • SBD config file must have SBD_WATCHDOG_DEV field
  • SBD config file must not have SBD_DEVICE field
  • SBD must no have any device configured and running

More info: https://documentation.suse.com/sle-ha/15-SP5/html/SLE-HA-all/cha-ha-storage-protect.html#sec-ha-storage-protect-diskless-sbd

How was this tested?

Tests added

@arbulu89 arbulu89 added the enhancement New feature or request label Feb 14, 2024
@arbulu89 arbulu89 marked this pull request as ready for review February 14, 2024 13:29
CDimonaco
CDimonaco reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM,

I left some comments

lib/trento/discovery/policies/cluster_policy.ex Outdated Show resolved Hide resolved
lib/trento/discovery/policies/cluster_policy.ex Outdated Show resolved Hide resolved
CDimonaco
CDimonaco approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM

@arbulu89 arbulu89 added the env Create an ephimeral environment for the pr branch label Feb 15, 2024
@arbulu89 arbulu89 merged commit 0e09b77 into main Feb 15, 2024
28 checks passed
@arbulu89 arbulu89 deleted the discover-diskless-sbd branch February 15, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CDimonaco CDimonaco CDimonaco approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

@EMaksy EMaksy Awaiting requested review from EMaksy

Assignees
No one assigned
Labels
enhancement New feature or request env Create an ephimeral environment for the pr branch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arbulu89 @CDimonaco