Indexserver & nameserver roles in cluster sites #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
added
enhancement
CDimonaco
force-pushed
the
indexserver_nameserver_role
branch
2 times, most recently
from
e2891f8
to
a8d6ef2
Compare
abravosuse
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Code apart, it looks good to me @CDimonaco !. For the sake of authenticity we might want to update the story book for HANA scale-out taking into account:
- in a given site, there can only be one master nameserver, the rest are slaves
- in a given site, there can only be one master indexserver, the rest are slaves or standby
- in the nodes that are not part of a site (other), there is no nameserver nor indexserver.
arbulu89
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Really nice job @CDimonaco
I put some comments, but it is great in general. No need for a new review (unless you have some question)
test/e2e/cypress/fixtures/hana-cluster-details/available_hana_cluster.js
Outdated
Show resolved
Hide resolved
CDimonaco
force-pushed
the
indexserver_nameserver_role
branch
2 times, most recently
from
d21ef23
to
bee9855
Compare
This reverts commit 09a8649.
arbulu89
force-pushed
the
indexserver_nameserver_role
branch
from
1a3a12d
to
8fbb7f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the support to nameserver and indexserver roles in cluster nodes.
The roles are extracted from node attributes.
The roles are separated by ":", the role string is splitted on the ":" character.
In scale up
4:P:master1:master:worker:masterNameserver is at index 3, and Indexserver at index 5
In scale out
master1:master:worker:masterNameserver is at index 1 and Indexserver at index 3
How was this tested?
Automated tests, frontend, backend and e2e