Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial software updates settings state and saga #2318

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Feb 15, 2024

Description

Adding initial state/selector/saga for software updates settings.
It should be enough to build initial loading of the settings.

  const {
    settings,
    error,
    loading,
  } = useSelector(getSoftwareUpdatesSettings());

Note: at the moment no distinction is made on errors.
We might want to iterate over the case we get something different from 404, which has the specific meaning of no settings are available, yet

How was this tested?

Automated tests

@nelsonkopliku nelsonkopliku self-assigned this Feb 15, 2024
@nelsonkopliku nelsonkopliku added enhancement New feature or request user story javascript Pull requests that update Javascript code labels Feb 15, 2024
@nelsonkopliku nelsonkopliku changed the title Suma settings state Initial software updates settings state and saga Feb 15, 2024
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments, but we can merge 👍

assets/js/state/softwareUpdatesSettings.js Show resolved Hide resolved
assets/js/state/sagas/index.js Outdated Show resolved Hide resolved
@nelsonkopliku nelsonkopliku merged commit e8d299d into main Feb 16, 2024
24 checks passed
@nelsonkopliku nelsonkopliku deleted the suma-settings-state branch February 16, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code user story
Development

Successfully merging this pull request may close these issues.

None yet

2 participants