Add tooltip for non-compliant saptune #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtorrero
force-pushed
the
noncompliant-saptune-tooltip
branch
from
53f1f99
to
1d1327b
Compare
arbulu89
reviewed
Feb 15, 2024
| @@ -9,7 +10,12 @@ function SaptuneTuningState({ state }) { | |||
| case 'not compliant': | |||
| return ( | |||
| <div className="flex"> | |||
| <HealthIcon health="critical" /> | |||
| <Tooltip | |||
| content="Run `saptune note verify` in the host for further details" | |||
There was a problem hiding this comment.
I don't think markdown works here as it is. You would need to wrap it up, something like:
<ReactMarkdown className="markdown" remarkPlugins={[remarkGfm]}>
Run `saptune note verify` in the host for further details
</ReactMarkdown>
Something like this would be good... |
|
As discussed with @arbulu89 we ended up removing the markdown as it adds very little value and looks quite odd |
CDimonaco
approved these changes
Feb 15, 2024
|
@rtorrero is it possible to wrap the text over two lines like screenshot below instead of one long line? |
|
@jagabomb should be good now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a tooltip to add further details when saptune is not compliant
Preview:
