Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch credentials and feed SUMA Config #2326

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Feb 16, 2024

Description

This PR adds fetching of the software updates settings when landing on /settings page and renders the SUMA config component.

Finer error handling to be addressed when the ux is defined.

How was this tested?

Automated tests.

@nelsonkopliku nelsonkopliku force-pushed the add-software-updates-settings branch 2 times, most recently from e9bfb44 to 5d39816 Compare February 19, 2024 08:51
@nelsonkopliku nelsonkopliku marked this pull request as ready for review February 19, 2024 08:54
@nelsonkopliku nelsonkopliku changed the title Rename Settings to SettingsPage Fetch credentials and feed SUMA Config Feb 19, 2024
@nelsonkopliku nelsonkopliku self-assigned this Feb 19, 2024
@nelsonkopliku nelsonkopliku added enhancement New feature or request javascript Pull requests that update Javascript code user story labels Feb 19, 2024
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nitpick

assets/js/pages/SettingsPage/SettingsPage.jsx Outdated Show resolved Hide resolved
@nelsonkopliku nelsonkopliku merged commit 14550ec into main Feb 19, 2024
24 checks passed
@nelsonkopliku nelsonkopliku deleted the add-software-updates-settings branch February 19, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code user story
Development

Successfully merging this pull request may close these issues.

None yet

2 participants