Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean tgzs after service manualrun #2336

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Clean tgzs after service manualrun #2336

merged 1 commit into from
Feb 19, 2024

Conversation

rtorrero
Copy link
Contributor

Description

This PR fixes the issue discussed in today's review meeting where some of the node_modules tgz's where left in the OBS project. This is due to the fact that we clean them up too early and osc service manualrun will recreate the node_modules from the obscpio that where updated since the last build.

By cleaning up after osc service manualrun we make sure no tgz are left in the working copy and send to OBS.

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be maybe test by hand first? 🙈

@rtorrero
Copy link
Contributor Author

Should be maybe test by hand first? 🙈

Tested in my fork, works fine 👍

@rtorrero rtorrero merged commit 3a990fb into main Feb 19, 2024
24 checks passed
@rtorrero rtorrero deleted the fix-leftover-tgzs branch February 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants